yknytt icon indicating copy to clipboard operation
yknytt copied to clipboard

Double jump sound doesn't play

Open blipdrifter opened this issue 1 year ago • 13 comments

The extra high-pitched jumping sound that normally plays when you double jump in KS is not present in YKnytt as of 0.5.1.

blipdrifter avatar Jul 24 '23 20:07 blipdrifter

tbh I just used to playing without double jump sound. so I have no plans to add it.

up-left avatar Sep 10 '23 15:09 up-left

... Seriously? What kind of "reason" is that?

Lt-knb avatar Sep 10 '23 15:09 Lt-knb

I get where you're coming from, but in this instance I feel it's more important to prioritize accuracy to the original source material, especially regarding base gameplay mechanics. Plus, it just feels weird to not have it after playing original KS for so long. At the very least you could have it on by default but have an option to turn it off...

blipdrifter avatar Sep 10 '23 16:09 blipdrifter

Exactly, well said

Lt-knb avatar Sep 10 '23 16:09 Lt-knb

patch confirmed working :), thanks!

ms2048 avatar Oct 14 '23 19:10 ms2048

patch confirmed working :), thanks!

where is the patch for the double jump sound?

djsolidsnake86 avatar Oct 23 '23 16:10 djsolidsnake86

So despite the patch already existing this is really not going to be fixed? As I've seen some renewed activity there recently, please clarify what is the actual plan for this.

ms2048 avatar Mar 27 '24 22:03 ms2048

You are right, adding features under pressure is not my choice.

up-left avatar Mar 28 '24 13:03 up-left

I see it now - your choice is to alienate the users instead, just because you can

ms2048 avatar Mar 28 '24 21:03 ms2048

Would you be willing to accept my fixes for open issues @up-left?

jakerosado avatar May 17 '24 03:05 jakerosado

I'm suspicious about that. Only if they contain real value and not personal preference.

up-left avatar May 18 '24 10:05 up-left

Yup, no personal preferences from me. Just resolving open issues like this one.

jakerosado avatar May 18 '24 16:05 jakerosado

Unfortunately, open issues are in a mess right now, most of them have a low result to effort ratio. Maybe it's possible to find a better upscaler, catch a left/right bug by ms2048, or switch to a sqlite (massive task). So I'm confused about which issues you can fix here.

up-left avatar May 19 '24 09:05 up-left