You-Dont-Need-JavaScript icon indicating copy to clipboard operation
You-Dont-Need-JavaScript copied to clipboard

Published 20 hours ago • verified publisher icon you-dont-need

Needs accessibility rules

Open COLABORATI opened this issue 7 years ago • 6 comments

Some of these examples do not work with keyboard only navigation.

COLABORATI avatar Jul 05 '16 10:07 COLABORATI

A lot of these examples would not work well for those with impairments that relay on web accessibility best practices to use web sites. This should be called out in your readme.

kylezinter avatar Jul 05 '16 17:07 kylezinter

A lot of these examples are really funny from a CSS point of view, but are really bad for accessibility:

  • modals without JS don't trap the keyboard focus in them
  • accordions are not working with keyboard
  • other will be vocalized as form elements
  • etc.

Please add a notice that these examples are proofs of concept, but really lack for accessibility.

nico3333fr avatar Jul 07 '16 14:07 nico3333fr

While many of these patterns are anti-patterns, they are pretty cool :) A little note in the readme about how they could harm accessibility could be a solve.

joe-watkins avatar Jul 12 '16 16:07 joe-watkins

I think the note has been added, should the topic be closed?

Julix91 avatar Jul 05 '17 22:07 Julix91

PR welcome

stevemao avatar Jul 05 '17 23:07 stevemao

can u assign this to me ?

Aditya-Singh2955 avatar Sep 26 '23 17:09 Aditya-Singh2955