You-Dont-Need-JavaScript icon indicating copy to clipboard operation
You-Dont-Need-JavaScript copied to clipboard

Modals in Demo 1 are added to the nav to the nav stack.

Open jskrzypek opened this issue 9 years ago • 4 comments

The states of the modals displayed in Demo 1 are placed on the nav stack, you can reproduce this on the pen by clicking open and closed the modals a few times and then clicking "back" in your browser.

I think violates users' expectations about modals and the back button, but YMMV.

jskrzypek avatar Jul 05 '16 09:07 jskrzypek

hey @jskrzypek assign me this issue, I can help.

2021eo3ar avatar Oct 11 '23 15:10 2021eo3ar

I'm not a maintainer, so I can't assign it. I think you can just submit a PR and include Closes #<issue #>

jskrzypek avatar Oct 11 '23 16:10 jskrzypek

@jskrzypek will you please explain me the problem in detail like what exactly do I need to make?

2021eo3ar avatar Oct 12 '23 14:10 2021eo3ar

Ah, no, sorry. This is from 7 years ago and I have absolutely no recollection of what the problem was. I don't even remember creating this issue.

jskrzypek avatar Oct 12 '23 15:10 jskrzypek