Yossef Hisham

Results 16 comments of Yossef Hisham

> Thank you, this looks good. If you have cycles to run benchmarks, this would be appreciated, you can check out this: https://github.com/mikemccand/luceneutil/blob/main/README.md#running-the-knn-benchmark. Thank you, Glad it looks good. Before...

Perfect. I will be waiting for updates on that matter. Thank you!

> @yossev FYI you'll need to resolve conflicts since another change touched the same lines of code. I'm curious if you had any success with benchmarking? Thanks for the heads-up!...

> I was checking to see what had been reverted, but I don't see it? #14979 didn't change Lucene99HnswVectorReader.java, right? Maybe you're referring to the conflicts since #14932 moved the...

Hello @jpountz, Please check the latest commit, i resolved the conflicts locally, and added back the optimization that was mentioned #14979. i will be waiting for further feedback.