yosifkit

Results 304 comments of yosifkit

The default was changed for the image because the PHP maintainer that made the "decorate_workers" improvements in FPM said that the only reason they didn't increase the default line length...

PHP 7.4 has been end of life for almost a full year (https://github.com/docker-library/php/pull/1349) and PHP 5.6 longer than that (https://github.com/docker-library/php/pull/768). Closing since this issue concerns EOL versions of PHP.

While that definitely would be a problem, I'd rather not complicate the Dockerfile with parts that make it uncertain how it was built. While build-args are not used in official...

> having a support in the template to generate debug Dockerfiles? I was finally able to come back to this; here is what I've come up with that fits with...

We unfortunately do not have build server bandwidth to support another variation of PHP builds, so we cannot currently do `fpm-zts`. I have a similar open issue about adding ZTS...

We don't really have the problem of files deleted without some other change in the Dockerfile context directory. `php` is the only one we maintain with a glob in the...

The downside is the extra initial churn to PRing and/or committing this to our other 30+ repos in order to keep their generate-stackbrew functions in sync. As for shellcheck warnings,...

@abdulrahman19, `ports:` only affects things hitting the docker host which then proxies to the correct port. From another container like nginx, you have to hit the correct port (`9000`). And...

> I don't get what do you mean by that? Isn't PHP-FPM use docker as a host! :slightly_frowning_face: > If you can explain it more to me I will be...

Rebased and applied templating. LGTM