Search Ux/Ui - Search workflow and search related issues

[mrjschulte]

1. When starting to search for the first time the Ui shouldn't be showing anything, because we haven't actually done any searching.
2. The "Recently Played" and "Favorite Games" sections should never be shown on the Search Results outcome.
3. Scrolling through the Search Results is Visually jarring as the tiles will "jump" when scrolling up at seemingly random intervals.
4. The Search results are at times questionable. For example, searching for "street" will also show us "Art of Fighting"? IS this because we are searching through the entire "info" text as well where street is mentioned somewhere? Search results should only query, system/title/year/romname data and not game info or other items.

[ToddLa]

• When starting to search for the first time the Ui shouldn't be showing anything, because we haven't actually done any searching.

  • an empty string (ie no search query) means "find everything", but can be changed.

• The "Recently Played" and "Favorite Games" sections should never be shown on the Search Results outcome. Scrolling through the Search Results is Visually jarring as the tiles will "jump" when scrolling up at seemingly random intervals.

  • dont know about the jarring part, but removing Fav and Recent is easy

• The Search results are at times questionable. For example, searching for "street" will also show us "Art of Fighting"? IS this because we are searching through the entire "info" text as well where street is mentioned somewhere? Search results should only query, system/title/year/romname data and not game info or other items.

  • "street" is getting found in the category, no we dont search the whole info! that would be crazy!
  • we search all text info, manufacturer, and driver too.

[ToddLa]

Jarring might just be icons async loading, only will only see "first time" but that should be a different issue not related to search.

[mrjschulte]

• Lets start with an empty string
• Lets remove Fav and Recent
• Yes, the "jarring" behavior must be the async loading bit, but it only shows up when going up through the search results. Give it a go and see if it happens to you as well.
• Street is being found in the category/genre? That seems like an odd classification eh?

[ToddLa]

There are iOS and tvOS considerations.

in iOS the search bar is always at the top of the view, and a empty string makes sense to show all.

[ToddLa]

I made the search changes, only for tvOS, in PR #317