superfile icon indicating copy to clipboard operation
superfile copied to clipboard

Pixelated image preview

Open mrjxtr opened this issue 1 year ago • 12 comments

Describe the bug When I want to preview an image, it is pixelated.

To Reproduce Steps to reproduce the behaviour:

  1. Download superfile
  2. Navigate to any directories with images.
  3. try to preview the images.

Expected behavior Shows me a clear image preview

Screenshots

Image

System information (please complete the following information):

  • OS: Arch Linux x86_64
  • Version: Linux 6.13.5-arch1-1
  • superfile Version: superfile-1.1.7.1-1

mrjxtr avatar Mar 04 '25 15:03 mrjxtr

@mrjxtr This is a known issue. We dont support image preview using image protocols yet, but only a pixelated preview using unicode characters.

Its something we will be fixing. But we might first prioritise some bugs fixes and performance issues.

lazysegtree avatar Mar 04 '25 16:03 lazysegtree

I see, thanks for the information.

mrjxtr avatar Mar 05 '25 07:03 mrjxtr

same issue and on top bad performance up and down when selecting images at least give us option turn off image preview

skarpinis avatar Mar 13 '25 12:03 skarpinis

@yorukot What do you think about a config like hide_image_preview ?

lazysegtree avatar Mar 13 '25 16:03 lazysegtree

@yorukot What do you think about a config like hide_image_preview ?

We already have toggle_file_preview_panel and default_open_file_preview Is it necessary to add this flag?

yorukot avatar Mar 14 '25 05:03 yorukot

hide image preview will be nice temporary fix

skarpinis avatar Mar 14 '25 17:03 skarpinis

@yorukot What do you think about a config like hide_image_preview ?

We already have toggle_file_preview_panel and default_open_file_preview Is it necessary to add this flag?

default_open_file_preview blocks everything

skarpinis avatar Mar 15 '25 18:03 skarpinis

@yorukot I think its okay to add disable_image_preview or hide_image_preview for now.

toggle_file_preview_panel hotkey and default_open_file_preview config blocks all file previews including text file preview, and preview of what content is in the currently selected directory .

lazysegtree avatar Mar 17 '25 11:03 lazysegtree

@lazysegtree sure!

yorukot avatar Mar 18 '25 11:03 yorukot

@skarpinis Check this out . What do you think about this flag ?

  • https://github.com/yorukot/superfile/pull/728

lazysegtree avatar Mar 21 '25 21:03 lazysegtree

@skarpinis Check this out . What do you think about this flag ?

  • https://github.com/yorukot/superfile/pull/728

Hi, well done thank you. Will test when is ready

skarpinis avatar Mar 21 '25 21:03 skarpinis

Hi, I am using superfile 1.4.0 and the image still show pixelated even on ghostty terminal with kitty protocol installed. I think I found the reason for it at least in my case.

This is mainly because I use tmux and the $TERM_PROGRAM is tmux while in a tmux session. If I close it all it is ghostty and it works correctly, but inside tmux it shows pixelated and I believe it will be because since the knownTerminals slice does not contain tmux it does not work. Both in and out of tmux sessions my $TERM variable is xterm-256color

vitorf7 avatar Nov 18 '25 13:11 vitorf7

I can reproduce it too. Image preview doesn't works in a tmux session inside kitty.

lazysegtree avatar Dec 01 '25 05:12 lazysegtree

Moved to https://github.com/yorukot/superfile/issues/1169

lazysegtree avatar Dec 01 '25 05:12 lazysegtree