superfile icon indicating copy to clipboard operation
superfile copied to clipboard

Flashing when switching between panels

Open Kadrian opened this issue 1 year ago • 4 comments

Love superfile, thank you for the great work!!

Describe the bug Flashing when switching between panels.

To Reproduce Steps to reproduce the behavior:

  1. Use a light themed terminal
  2. Open spf
  3. hit b and m and occasionally, observe the flashes

Expected behavior No flashing

Screenshots

https://github.com/MHNightCat/superfile/assets/1403093/e780f87d-ea85-4939-91f2-7a13b652caf5

System information (please complete the following information):

  • OS: Mac OS 14.4.1, iTerm 3.4.23
  • Superfile Version 1.1.2

Kadrian avatar May 11 '24 10:05 Kadrian

I think that's a little hard to fix...

yorukot avatar May 13 '24 12:05 yorukot

Using Zellij it is even worse. It flickers (flashes) with every cursor move. If superfile is a serious tool to consider this must be fixed.

r00tc0d3 avatar May 13 '24 16:05 r00tc0d3

I do have this problem when I use zellij, but it doesn't seem to happen when I don't. zellij: https://github.com/yorukot/superfile/assets/107802416/1f440a1c-dc57-4245-83e7-56ce30a326c5 no zellij: https://github.com/yorukot/superfile/assets/107802416/48fd5ae8-4e95-4e57-baa3-487af589c0fa

Here's a simple program from bubbletea that I used to test it (just to make sure it's not a performance issue with superfile). https://github.com/yorukot/superfile/assets/107802416/b82f78de-6b65-4c51-991e-c8d86aa9008c

In my opinion, this is a bubbletea issue. I will create an issue in the bubbletea repository!

yorukot avatar Jun 01 '24 14:06 yorukot

A quick update: Someone has created a new PR in the bubbletea repo to address the flickering issue caused by it, but it hasn’t been merged yet. If you need an immediate fix, you can clone my fork from the following branch: git clone https://github.com/yorukot/superfile -b flickering and build it yourself.

To resolve this issue, I referenced the bubbletea PR directly by pointing to the contributor's repository in my project’s dependencies. This way, the flickering problem is fixed without waiting for the PR to be officially merged.

yorukot avatar Oct 05 '24 02:10 yorukot