Troy Gerwien

Results 29 comments of Troy Gerwien

Hi @durlabhjain, abstracting out the filesystem is a useful change, since it's non-core to what the module does and makes it more flexible. I'd be happy to accept it, although...

Thanks for the PR @etnperlong! This seems like a good change. There are some small differences in field interpretation, but we already allow VPF9 which would have the same issues...

Thanks for the contribution @banned-historical-archives! Can you post here some info about the bug that this PR is fixing? Which dbf versions does this apply to? Would this change break...

@banned-historical-archives thanks for the additional info, it makes perfects sense. Would it be ok to add the above dbf file to the test suite? It would be great to have...

Hi @banned-historical-archives, just asking again if the files you've linked can be used as test fixtures? I'm happy to take this PR to fix the decoding issue as long as...

Thanks @banned-historical-archives! Your fixes have been merged and published in v1.9.1.

Closing due to inactivity. Feel free to re-open to address the [review feedback](https://github.com/yortus/DBFFile/pull/60#pullrequestreview-817118787).

Closing as inactive - feel free to reopen to address my [previous comment](https://github.com/yortus/DBFFile/issues/70#issuecomment-1167123172) so this can be further investigated.

Closing due to inactivity. Feel free to re-open to add a test fixture with the 0xf5 file version - I'm happy to merge this PR if it includes test coverage.

Closing due to inactivity. Feel free to re-open to address the points made in my previous comment.