yorkie icon indicating copy to clipboard operation
yorkie copied to clipboard

Update protocol to support multi-user undo and redo on Text.edit

Open hyemmie opened this issue 1 year ago • 1 comments

What this PR does / why we need it: A new operation, EditReverse, is proposed to support multi-user undo and redo functionality in text.edit. (yorkie-team/yorkie-js-sdk#635) To support this, the server also needs to modify the protocol buffer. This PR defines the new EditReverse operation and modifies the protocol buffer to allow replicas to send and receive EditReverse operations.

Which issue(s) this PR fixes:

It fixs #49 partially.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • [x] Added relevant tests or not required
  • [x] Didn't break anything

hyemmie avatar Sep 15 '23 08:09 hyemmie

Codecov Report

Patch coverage has no change and project coverage change: -0.28% :warning:

Comparison is base (940941a) 49.47% compared to head (57e196e) 49.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
- Coverage   49.47%   49.19%   -0.28%     
==========================================
  Files          69       69              
  Lines        9951    10007      +56     
==========================================
  Hits         4923     4923              
- Misses       4512     4568      +56     
  Partials      516      516              
Files Changed Coverage Δ
api/converter/from_pb.go 40.08% <0.00%> (-2.02%) :arrow_down:
api/converter/to_pb.go 50.00% <0.00%> (-2.75%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 15 '23 08:09 codecov[bot]