yorkie
yorkie copied to clipboard
fix : run ci in multi env os
What this PR does / why we need it:
- Workflow that automatically tests according to the environment (windows, ubuntu, macOS) when PR comes in.
- coverage has uploaded in ubuntu env
Which issue(s) this PR fixes:
Fixes #293
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
github actions will be run like below screenshot

Additional documentation:
Checklist:
- [ ] Added relevant tests or not required
- [ ] Didn't break anything
Codecov Report
Merging #374 (553f90a) into main (bbd45e3) will increase coverage by
1.64%
. The diff coverage isn/a
.
:exclamation: Current head 553f90a differs from pull request most recent head ece2134. Consider uploading reports for the commit ece2134 to get more accurate results
@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 46.63% 48.27% +1.64%
==========================================
Files 70 67 -3
Lines 5901 5574 -327
==========================================
- Hits 2752 2691 -61
+ Misses 2846 2590 -256
+ Partials 303 293 -10
Impacted Files | Coverage Δ | |
---|---|---|
server/config.go | 38.09% <0.00%> (-6.00%) |
:arrow_down: |
api/types/updatable_project_fields.go | 96.66% <0.00%> (-3.34%) |
:arrow_down: |
api/types/project.go | 100.00% <0.00%> (ø) |
|
server/backend/backend.go | 0.00% <0.00%> (ø) |
|
pkg/document/change/checkpoint.go | 92.00% <0.00%> (ø) |
|
server/backend/database/mongo/indexes.go | 50.00% <0.00%> (ø) |
|
pkg/document/crdt/strings.go | ||
api/types/create_project_fields.go | ||
pkg/document/crdt/object.go | ||
pkg/document/crdt/primitive.go | ||
... and 30 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sinkyoungdeok Thank you! but it's valid pattern. ref. we dont have to add new line on this failed line.
i dont know why lint was failed only windows env.
It seems to be related to this issue: mgechev/revive#607
I think it would be good to close this PR for now and open it later when working again.