yorkie icon indicating copy to clipboard operation
yorkie copied to clipboard

Add setting index value to array

Open ppeeou opened this issue 2 years ago • 3 comments

What this PR does / why we need it:

we can insert a value at a specific index into arrray yorkie-sdk-js also needs work

Which issue(s) this PR fixes:

Fixes #215

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • [x] Added relevant tests or not required
  • [x] Didn't break anything

ppeeou avatar Jul 27 '21 01:07 ppeeou

Codecov Report

Merging #221 (651f853) into main (7c254bb) will decrease coverage by 0.87%. The diff coverage is 27.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   57.13%   56.26%   -0.88%     
==========================================
  Files          45       45              
  Lines        3859     3956      +97     
==========================================
+ Hits         2205     2226      +21     
- Misses       1454     1529      +75     
- Partials      200      201       +1     
Impacted Files Coverage Δ
api/converter/from_pb.go 61.17% <0.00%> (-3.03%) :arrow_down:
api/converter/to_pb.go 78.51% <0.00%> (-3.98%) :arrow_down:
pkg/document/json/array.go 35.55% <23.07%> (-0.81%) :arrow_down:
pkg/document/json/rga_tree_list.go 48.54% <36.70%> (-6.71%) :arrow_down:
api/converter/to_bytes.go 85.15% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c254bb...651f853. Read the comment docs.

codecov[bot] avatar Jul 27 '21 01:07 codecov[bot]

@hackerwins Is it correct to proceed in this direction🤔?? I want to check yorkie-sdk-js before working

ppeeou avatar Jul 31 '21 07:07 ppeeou

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


hyunwoo.jo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 15 '22 03:01 CLAassistant

The users who requested this feature are not currently seeking it. Therefore, I'll close this PR for now and will reopen it when new requests for the feature arise.

hackerwins avatar Oct 16 '23 00:10 hackerwins