yorkie-js-sdk icon indicating copy to clipboard operation
yorkie-js-sdk copied to clipboard

Published 20 hours ago • verified publisher icon yorkie-team

Add benchmark tests to JS SDK

Open hackerwins opened this issue 2 years ago • 1 comments

Description:

Add benchmark tests to JS SDK.

@mojosoeun and @ppeeou recently added benchmark tests in CI. But there are still only a constructor test and other tests related to JS SDK.

Let's add benchmark tests we wrote in Go to JS SDK.

  • [x] Document/constructor_test
  • [ ] Document/status_test
  • [x] Document/equals_test
  • [ ] Document/nested_update_test
  • [ ] Document/delete_test
  • [ ] Document/object_test
  • [ ] Document/array_test
  • [ ] Document/text_test
  • [ ] Document/text_composition_test
  • [ ] Document/rich_text_test
  • [ ] Document/counter_test
  • [ ] Document/text_edit_gc_100
  • [ ] Document/text_edit_gc_1000
  • [ ] Document/text_split_gc_100
  • [ ] Document/text_split_gc_1000
  • [ ] Document/text_100
  • [ ] Document/text_1000
  • [ ] Document/array_1000
  • [ ] Document/array_10000
  • [ ] Document/array_gc_100
  • [ ] Document/array_gc_1000
  • [ ] Document/counter_1000
  • [ ] Document/counter_10000
  • [ ] Document/rich_text_100
  • [ ] Document/rich_text_1000
  • [ ] Document/object_1000
  • [ ] Document/object_10000

Why:

  • We can observe the performance of the JS SDK and find points for improvement.

hackerwins avatar Jun 06 '22 07:06 hackerwins

Could I try this issue?

parkeunae avatar Jul 21 '22 12:07 parkeunae

Could I try this issue? Or is this issue fixed?

If I can try to fix the issue, could you recommend documents or codes to focus on because this is my first time on this project @hackerwins

blacktoast avatar Feb 06 '23 10:02 blacktoast

@blacktoast Thank you for your interest in contributing.

We were moving benchmark codes written in Go into the file below in JS SDK.

  • Go SDK
    • benchmarks: https://github.com/yorkie-team/yorkie/blob/e87d9d351ed08d5f305f6090bc1c301bba92057e/test/bench/document_bench_test.go
    • results: https://github.com/yorkie-team/yorkie/actions/runs/4051666944/jobs/6970221834#step:11:5
  • JS SDK
    • benchmarks: https://github.com/yorkie-team/yorkie-js-sdk/blob/main/test/bench/document_test.ts
    • results: https://github.com/yorkie-team/yorkie-js-sdk/actions/runs/4091275719/jobs/7055248575#step:10:1

Please let me know if you have any additional questions.

hackerwins avatar Feb 06 '23 11:02 hackerwins

Thanks, I will try

blacktoast avatar Feb 07 '23 13:02 blacktoast