Yorick

Results 114 comments of Yorick

https://github.com/pb33f/libopenapi-validator/issues/53

This comment contains a summary: https://github.com/replicate/cog/issues/1186#issuecomment-2011832395 We could try to get away with kin-openapi, that would just require fixing the test for the version in https://github.com/replicate/cog/pull/1552

> What is actually wrong with `kin-openapi`? No OpenAPI v3.1 support: https://github.com/getkin/kin-openapi/issues/230#issuecomment-1002659224 However, it seems we happen not to use any of the unsupported 3.1 features. Would be good to...

Here's a list of changes: https://www.openapis.org/blog/2021/02/16/migrating-from-openapi-3-0-to-3-1-0 . My concern here is that these schemas are generated from user input by pedantic, so we don't necessarily control it when they break....

CI failure: ``` python/cog/predictor.py:28:1: I001 [*] Import block is un-sorted or un-formatted python/cog/server/http.py:27:1: I001 [*] Import block is un-sorted or un-formatted python/cog/types.py:1:1: I001 [*] Import block is un-sorted or un-formatted...

Interesting! It's probably related to using the same input/output file paths. Try instead to spawn multiple docker containers with a different `--gpus` flag.

Looks like the problem is openapi 3.1.0 support starting in fastapi 0.99.0

kin-openapi could be helped along with some sponsoring maybe? https://github.com/getkin/kin-openapi/issues/230#issuecomment-1002659224

Our use of the schema in cog is limited to https://github.com/replicate/cog/blob/main/pkg/cli/predict.go#L170. I think all of these libs should be good enough to support that. I also found another library: https://github.com/swaggest/openapi-go...