Davide Mauri
Davide Mauri
Done, it was easier that I thought :) Let me know if this is better.
> This is looking pretty good. > > Can you open a breaking change doc issue: [New breaking-change template](https://github.com/dotnet/docs-aspire/issues/new?template=04-breaking-change.yml), since we are changing the default SKU here. We should have...
Anything left to do in order to have this PR merged?
> @eerhardt make sure we expose Sqlsku and not a string (see primitive obsession) If that is needed, then adding `WithSku` is not enough, as there is no "free" Sku,...
> What about only `WithSku()` and use a constant for the free/basic/... offers that return the correct `SqlSku`? Not sure I follow. There is no "free" Sku...you can set the...
> > Not sure I follow. There is no "free" Sku...you can set the free offer option and then the Sku will be set automatically to "GP_S_Gen5_2"...but you can set...
For example: ``` var db = sql.AddDatabase("db", "dbName").WithSku(SkuName.FreeOffer); Assert.Equal("GP_S_Gen5_2", db.Sku.Name); Assert.Equal(true, db.IsFreeOfferEnabled); ```
@davidfowl @sebastienros Any feedback on this proposal?
So, to summarize: - No `WithSku()` method - When creating the Azure SQL resource, the Aspire Azure SQL resource will deploy the free Azure SQL DB offer by default -...
I made the changes, but while doing it I realized that having a `WithSku` is really just better. With that you can define the sku for each database, so you...