gofast icon indicating copy to clipboard operation
gofast copied to clipboard

pool.go doesn't have any explanation of what it's for

Open ijt opened this issue 6 years ago • 2 comments

I'm trying to decide whether to use a PoolClient, but pool.go doesn't say what benefit it has. I guess it's supposed to be for performance but I don't see any benchmarks that would give evidence for that.

I hope this isn't taken as too critical. I'm glad you wrote this library and I'm getting nice results from it.

ijt avatar Jun 28 '18 22:06 ijt

Okay, I see there's a section in the README, but I still think it would be more convincing with a benchmark.

ijt avatar Jun 28 '18 22:06 ijt

Thanks for the advice. I'll try to come up with one.

Or, you can send me a PR for it :-)

yookoala avatar Jun 30 '18 07:06 yookoala