Pytorch-NLU icon indicating copy to clipboard operation
Pytorch-NLU copied to clipboard

Published 20 hours ago • verified publisher icon yongzhuo

Add conventional commits

Open shairez opened this issue 4 years ago • 4 comments

Following #8

I've added commitizen, conventional-changelog and commitlint (with a commit husky hook) to make sure the future commits follow the convention.

Plus added a fix for eslint on windows machines

shairez avatar Sep 06 '20 09:09 shairez

Hey Shai Thanks for your PR! We won't be able to accept this kind of change without internal discussion and RFC process

Bnaya avatar Sep 06 '20 11:09 Bnaya

Sure thing

It didn't take long to do, so feel free to reject it if needed 😄

shairez avatar Sep 06 '20 11:09 shairez

Hey, the CLA is live.

Shai can you please sign it? (saying "I agree to the CLA" in a GitHub comment is sufficient for now assuming your GitHub account and email are linked) - It transfers your kidneys ownership of committed code to us after you commit so we can consume the code with a different license internally.

benjamingr avatar Sep 22 '20 07:09 benjamingr

"I agree to the CLA" 😄

shairez avatar Sep 22 '20 08:09 shairez