electrasmart-custom-component icon indicating copy to clipboard operation
electrasmart-custom-component copied to clipboard

Update climate.py

Open idisis opened this issue 2 years ago • 3 comments

Add missing properties so that Google Assistant can control A/C temperature.

idisis avatar Aug 30 '22 07:08 idisis

The change has been tested and works properly. Google assistant was able to control the A/C temperature after this change.

idisis avatar Aug 30 '22 07:08 idisis

@idisis , are you sure this change works? It looks as if you're calling() the target_temperature property as if it was a method. Am I missing something?

yonatanp avatar Sep 03 '22 05:09 yonatanp

Hi, Sorry about that. I fixed it locally on my end and then re-typed it straight on github, instead of cloning the repo. Nice catch though :)

But I found that the fix needs some more work. Originally, the assistant could increase/decrease the temperature (Hi Google, warm up/cool down ...). This fix allows you to specify the desired temperature (Hi Google, set ... temperature to 25 degrees). But it also implicitly changes the A/C mode to auto (heat/cool). It makes sense, as in HA the temperature range is a feature of the auto mode...

I'll make another PR with a more complete solution.

On Sat, Sep 3, 2022, 08:52 yonatanp @.***> wrote:

@idisis https://github.com/idisis , are you sure this change works? It looks as if you're calling() the target_temperature property as if it was a method. Am I missing something?

— Reply to this email directly, view it on GitHub https://github.com/yonatanp/electrasmart-custom-component/pull/32#issuecomment-1236055313, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3PJUK3N52CVQWWY4EVOSDV4LRRLANCNFSM6AAAAAAQADUVSA . You are receiving this because you were mentioned.Message ID: @.***>

idisis avatar Sep 06 '22 04:09 idisis

Sounds good. I’m closing this PR for now.

yonatanp avatar Dec 10 '22 20:12 yonatanp