Embedding project reference targets in multiple targets

[mqzkim]

To solve this, https://github.com/yonaskolb/XcodeGen/issues/933 Add dependencySet to avoid duplicate project reference targets

• Added test code for MultipleXcodeProject with MultipleTargetDependencies

~Also)~ ~- Project framework would be included frameworkFiles.~

[PaulTaykalo]

if there are mutliple targets with the same depdency on same target from project reference, this fix will set incorrect dependencies

[mqzkim]

if there are mutliple targets with the same depdency on same target from project reference, this fix will set incorrect dependencies

@PaulTaykalo Would you provide any example that I can reproduce your issue?

[simonpierreroy]

I tried to see what an Xcode generated setup would look like. It seems this PR is definitely on the correct path. Unique PBXContainerItemProxy are needed per target.

Here Parent and ParentTests are linking Child1 and Child2.

@PaulTaykalo Did you have more info on the issues with this PR?

Test.zip

[PaulTaykalo]

Tried this branch again - have the same result. this update will break dependencies generation with complex depencies.

This is an oversimplified example of our project. If arrows are dependencies, and B is target from project reference, then for project C, dependency on B target is not present in the XML. (Or it's invalid. Hard to tell).

graph TD
A.pbxproj --> B[Target from B.pbxproj]
C.pbxproj --> B[Target from B.pbxproj] 
linkStyle 1 stroke: red, stroke-width: 2px;

I can't provide more detailed explanation on this, but this PR breaks that part. Not sure if I'll be able to drill down to the root cause of the problem

[PaulTaykalo]

Like these deps are not generated:

Incorrect (this PR)

Correct