fix: correct indentation in deployment template for nodeSelector
The terminationMessagePath and imagePullPolicy were incorrectly placed outside the container spec, causing YAML parse errors when nodeSelector was defined. This fix moves these properties to their correct location within the container definition.
Fixes: YAML parse error on deployment.yaml line 50
Description
Fixes a YAML parsing error in the deployment template when nodeSelector is configured.
Problem
When setting prometheusExporter.deployment.nodeSelector, the Helm chart fails with:
Root Cause
The terminationMessagePath and imagePullPolicy properties were placed at the wrong indentation level, appearing after the nodeSelector/affinity/tolerations blocks instead of inside the container spec.
Solution
Moved terminationMessagePath and imagePullPolicy to their correct location within the container definition.
Testing
- [x] Tested with
helm template - [x] Tested with
helm lint - [x] Successfully deployed to GKE cluster with nodeSelector configured
Chart Version
Affects version: 0.2.4
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.02%. Comparing base (42443ec) to head (a1ab8b5).
:warning: Report is 8 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 44.02% 44.02%
=======================================
Files 67 67
Lines 4502 4502
=======================================
Hits 1982 1982
Misses 2248 2248
Partials 272 272
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Hi @maurohoj
Please run
docker run --rm --volume "$(pwd):/helm-docs" jnorwood/helm-docs:latest
Resolved in #535