kor icon indicating copy to clipboard operation
kor copied to clipboard

Adding option for podAnnotations on the deployment level

Open DMSwimTech opened this issue 1 year ago • 3 comments

What this PR does / why we need it?

Currently the project support integration with Prometheus out of the box. To allow other provider such Datadog to collect metric we need to provide podAnnotation field Datadog annotations integration

PR Checklist

  • [ ] This PR adds K8s exceptions (false positives)
  • [x] This PR adds new code
  • [x] This PR includes tests for new/existing code
  • [x] This PR adds docs

GitHub Issue

Closes [XX-XX]

Notes for your reviewers

DMSwimTech avatar Nov 06 '24 16:11 DMSwimTech

@DMSwimTech Thanks for the contribution. Can you bump the chart version? This is a requirement for any chart changes

yonahd avatar Nov 06 '24 18:11 yonahd

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.38%. Comparing base (9cd0aba) to head (0f4d310). Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   43.38%   43.38%           
=======================================
  Files          63       63           
  Lines        4020     4020           
=======================================
  Hits         1744     1744           
  Misses       2030     2030           
  Partials      246      246           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 06 '24 18:11 codecov-commenter

@DMSwimTech will you be fixing this PR or should I close it?

yonahd avatar Feb 06 '25 08:02 yonahd