Yonah Dissen

Results 24 comments of Yonah Dissen

> fixes #92 > > This PR is still WIP, as it lacks parallel processing of the namespaces as well as unit tests, could you please review if in principle...

Strange that this came back Looking what changed

> fixes #92 > > This PR is still WIP, as it lacks parallel processing of the namespaces as well as unit tests, could you please review if in principle...

@hrytsai this worked fine in 0.3.7?

Very strange I cannot seem to replicate this error. There are 2 places in the code that call the list namespaces api and your command hits neither of them. Let...

> The issue results from the `retrieveUsedClusterRoles()` function that is called in `pkg/kor/clusrterroles.go`. > > ``` > func retrieveUsedClusterRoles(clientset kubernetes.Interface, filterOpts *filters.Options) ([]string, error) { > > //Get a list...

> @yonahd @luisdavim @doronkg, I finally found time and adding some more testing to the namespace removal - but I was not following if json configs with resources to skip...

Let me know when this is ready for review. This is a massive pr and will take quite a while to review

> Happy to work on this and get the initial scan. Assigned. Thank you!

@pbr0ck3r are you available for contributing this or should I look to reassign it?