hashids-java icon indicating copy to clipboard operation
hashids-java copied to clipboard

Added "separators" customization, NULL pre-checks, and Javadoc comment blocks to all constructors

Open randolf opened this issue 6 years ago • 1 comments

Added a new Hashids constructor to support customized "separators" plus a pre-check for NULL that prevents a NullException by defaulting to DEFAULT_SEPS (this behaviour is modeled after the "salt" pre-check for NULL).

Added a pre-check for NULL for the custom "alphabet" that prevents a NullException by defaulting to DEFAULT_ALPHABET (this behaviour is also modeled after the "salt" pre-check for NULL).

Added rudimentary comments for existing constructors for better Javadoc output. Added relevant details about the new constructor that supports custom "separators" (should this also be mentioned in the documentation on the web site?).

randolf avatar Jan 16 '19 10:01 randolf

@randolf , are you still able to fix those issues raised by @Jon-Hopper?

0x3333 avatar May 20 '21 17:05 0x3333