Sebastian Munz

Results 21 comments of Sebastian Munz

I am really hesitant adding this. There are similar APIs for Switzerland, Norway or the US. But our focus with valvat has always been validation of european VAT numbers for...

@pastullo You are absolutely right about my earlier statement being somewhat arbitrary. There are undoubtedly business cases which would benefit from added support for VAT numbers from UK. But there...

I started to (re)implement the solution by @jarthod in the [nethttp branch](https://github.com/yolk/valvat/tree/nethttp). It should behave like the code in the hmrc branch; except it requires to pass in the `:uk`...

@jarthod Thx for looking into the new branch. In ActiveModel you have to set the `:uk` option on the `lookup` key: validates :vat_number, valvat: {lookup: {uk: true}, allow_blank: true, checksum:...

Ahh, you found it by yourself! Sorry, we commented in parallel ;-) One question: I implemented it with the `:uk` option defaulting to `false` for backwards compatibility to don't break...

Thanks alot for your suggestion. Makes sense; I guess I'll go with 1.2

I released v1.2 with support for lookup of UK VAT numbers via HMRC.

@nicolas-brousse A caching option for VAT lookups with the caching option behind a proxy ala geocoder seems to be reasonable. I feel a slight hesitation for it, because strictly speaking...

@ksol It seems to me both of your examples are too specific and therefor would be out of the scope for this gem. It wouldn't make sense for me to...

Hi Jonas, yes, this would be a good addition. But please take a look at the implementation of the UK HMRC Service. I guess I would deactivate the lookup by...