ArangoDB-NET icon indicating copy to clipboard operation
ArangoDB-NET copied to clipboard

Published 20 hours ago • verified publisher icon yojimbo87

added the value of parameter into Exception message for easier debuging

Open dvdnhm opened this issue 5 years ago • 4 comments

System.Exception: Invalid Value: [val]

image

console version: image

dvdnhm avatar Apr 12 '19 15:04 dvdnhm

added a fix for pulling byte[] from db

dvdnhm avatar Apr 30 '19 21:04 dvdnhm

Hi, thanks a lot for the pull request! It seems that these changes affect mainly fastJSON external library. Would you be able to create some unit test cases which demonstrate the bug in the fastJSON library and rerun its test suite to find out whether there is not some regression?

yojimbo87 avatar May 01 '19 19:05 yojimbo87

To be honest; I don't know how to write tests, at least not yet. I will try to do it but might take a while.

dvdnhm avatar May 01 '19 19:05 dvdnhm

That's ok, take your time. My main concern here is that this change might break or affect the existing functionality of the driver. That's why I would rather like to have a test case which demonstrates the bug in fastJSON library. Once this is proven, pull request can be created in fastJSON repo, fixed there and then the library can be updated within the driver.

yojimbo87 avatar May 01 '19 19:05 yojimbo87