protolint icon indicating copy to clipboard operation
protolint copied to clipboard

About the version config setup for the project

Open chenrui333 opened this issue 2 years ago • 3 comments
trafficstars

While trying to include this tool into homebrew-core, I saw the version config is actually weird for the project. Why not just use one config rather than two?

Like merge -X github.com/yoheimuta/protolint/internal/cmd/protocgenprotolint.version into -X github.com/yoheimuta/protolint/internal/cmd.version. Thanks!

chenrui333 avatar Dec 11 '22 04:12 chenrui333

@chenrui333 Thank you for including this tool into homebrew-core! Sounds great. I'm checking it out soon.

yoheimuta avatar Dec 29 '22 10:12 yoheimuta

@chenrui333 I refreshed my memory. I just had no motivation to merge the existing cmd.go, when I added protoc-gen-protolint to this project later.

So, you have a point and it's a good first issue 👍

yoheimuta avatar Dec 29 '22 10:12 yoheimuta

We are aligned, thanks! :)

chenrui333 avatar Jan 04 '23 00:01 chenrui333