Finite icon indicating copy to clipboard operation
Finite copied to clipboard

Add new maintainers

Open Revisor opened this issue 9 years ago • 9 comments

It's a nice and useful library, but it needs more care - solve outstanding issues, tag release versions regularly.

If you don't have the time or willpower to work on it, add more maintainers. Please don't let it die.

Revisor avatar Nov 27 '15 11:11 Revisor

:+1:

ksn135 avatar Nov 27 '15 11:11 ksn135

Anyone who (like me) likes the 1.0 branch better than where master was heading is welcome to join me on https://github.com/RonRademaker/Finite, I'll actively maintain this 1.0 fork and use semver for new releases.

RonRademaker avatar Nov 27 '15 11:11 RonRademaker

@RonRademaker haven't looked too much into master vs 1.0, what were the major changes?

phillipsnick avatar Nov 27 '15 11:11 phillipsnick

@RonRademaker I'm happy with the master branch for both my Laravel 4.2 and 5.1 applications.

tortuetorche avatar Nov 27 '15 11:11 tortuetorche

@phillipsnick basically the StatefulInterface has been replaced by a StateAccessor that by default uses a public variable state. It's more like the winzou/statemachine I think. I started using and went back to 1.0 fast (it's a matter of taste of course).

RonRademaker avatar Nov 27 '15 12:11 RonRademaker

My preferred solution would be for @yohang to add more maintainers to this repo. This is a known quantity, it has articles written about it, two weeks ago someone mentioned it by the way at a conference - it has the most attention in bug hunting and issues.

If that doesn't work, a fork would also be a solution, but forks always have to start from the scratch regarding visibility which might be a disadvantage.

Revisor avatar Nov 27 '15 12:11 Revisor

Hi,

I tweeted about adding new maintainers few weeks ago, I agree, send me a mail if interested.

And I'll have some time for updates very soon.

yohang avatar Nov 27 '15 12:11 yohang

Thanks, Yohan, we use the library, love it and would like to help. We'll send an email to you.

Revisor avatar Nov 27 '15 12:11 Revisor

Hi @yohang,

Can you add me as a contributor, please? To refresh your mind, I'm the author of Finite State Machine and Finite Audit Trail traits for Laravel.

I'll not be a big contributor, but I can send fix, from time to time.

Cheers, Tortue Torche

tortuetorche avatar Nov 27 '15 12:11 tortuetorche