Finite icon indicating copy to clipboard operation
Finite copied to clipboard

Published 20 hours ago • verified publisher icon yohang

removing unneccessary state accessor initialization in costructor

Open realshadow opened this issue 8 years ago • 5 comments

This should fix issue described in #117 . I have tried different initializations on my end and seems everything is fine.

@stephenjwinn Can you please confirm if this does indeed fix your issue? @yohang Can you please confirm this does not break something I am not aware of? It should not since you need to bind an object to the state machine first where the state accessor is set to the default one

realshadow avatar Apr 19 '16 06:04 realshadow

Humm, I merged a bit too fast. I'll have a look at the issue today.

yohang avatar Apr 19 '16 07:04 yohang

@yohang could you please fix and release this? It is a problem that has been for over a year and still not fixed. I need this.

func0der avatar Feb 20 '18 12:02 func0der

@yohang ?

func0der avatar Apr 08 '20 13:04 func0der

I dont think this repository is still being maintained. I am using my own fork with the PR for 4 years now

realshadow avatar Apr 25 '20 11:04 realshadow

Is this change already in the master without closing/merging this or attribution somehow?

Or was this PR duplicated by #115 ? Changes seem to be there: https://github.com/yohang/Finite/blob/master/src/Finite/Loader/ArrayLoader.php#L58

func0der avatar May 10 '22 14:05 func0der