Holodeck/Thunderdome now load from templates

Open JohnFulpWillard opened this issue 1 year ago • 4 comments

Document the changes in your pull request

Holodeck & Admin Thunderdome now load from templates, rather than being stored at Centcom and copied constantly.

This means that adding new holodeck maps are easier to do, and they do not need to be loaded on roundstart, eating away at init times. It also means that it is now more on-par with TG, making it easier to port things in the future, and may help later down the line when I make a new attempt at lazyloading. Also removes our reliance on object duplication, as it is very unreliable and easy to break.

Extra notes

I've modularized the yog-unique holodeck stuff, and commented out the TG holodecks that yog does not have. I also removed the medical one from requiring emag, to keep consistent with current balance. Burn test was removed because it was causing some problems. On TG it just spawns a ton of plasma, while on Yog it's just a pit of lava. May be worth just porting TG's version of it instead of trying to fix the current, but I don't think it's really worth at the moment. If there's any game-changing behavior, please let me know.

This will conflict with https://github.com/yogstation13/Yogstation/pull/19799