Yogstation icon indicating copy to clipboard operation
Yogstation copied to clipboard

Remove vent clog (scrubber overflow) events from rotation

Open ynot01 opened this issue 1 year ago • 6 comments

Document the changes in your pull request

The performance impact of these scrubbers are wholly unsanitary and I believe they are the reason for a recent crash (43458)

Nanotrasen has since improved their scrubber cleaning systems which somehow get chemicals in them despite being atmos ports

Changelog

:cl:
rscdel: Removed vent clog events from rotation /:cl:

ynot01 avatar Oct 22 '22 00:10 ynot01

Remove dont disable

alexkar598 avatar Oct 22 '22 00:10 alexkar598

Remove dont disable

Delete, erase it don't disable

warface1234455 avatar Oct 22 '22 01:10 warface1234455

Also the meteor event is also laggy as hell

warface1234455 avatar Oct 22 '22 01:10 warface1234455

honestly, lag or no lag, i think these suck enough to go anyway - they aren't fun to play around, they just put everyone outside maints on pause for a while and sometimes fuck you up with acid

Cartlord avatar Oct 22 '22 01:10 Cartlord

Also the meteor event is also laggy as hell

meteors however dont have PERSISTENT lag that hangs around >10m post event

VaelophisNyx avatar Oct 22 '22 01:10 VaelophisNyx

How about we just merge the fixes instead rip my tg pr.

JamieD1 avatar Oct 22 '22 13:10 JamieD1

i trust jamie that this is not the core of the issue

ynot01 avatar Nov 07 '22 13:11 ynot01

this is once again relevant

ynot01 avatar Nov 28 '22 22:11 ynot01

Remove it

RG4ORDR avatar Nov 28 '22 22:11 RG4ORDR

tg hasn't even fixed this

Simplehorror avatar Nov 28 '22 22:11 Simplehorror

Jamie wants to test the scrubber events when the server gets an upgrade so the code stays until then

ynot01 avatar Nov 28 '22 22:11 ynot01

Jamie wants to test the scrubber events when the server gets an upgrade so the code stays until then

just improve performance

TheGamerdk avatar Nov 29 '22 22:11 TheGamerdk

I'm wondering what the profiler looks like when the scrubber event runs.

BurgerLUA avatar Dec 02 '22 11:12 BurgerLUA

Seems like gus fixed the lag with #17263

neeshacark avatar Jan 08 '23 21:01 neeshacark