Yogstation icon indicating copy to clipboard operation
Yogstation copied to clipboard

Add a new advanced decontamination suit storage unit

Open warface1234455 opened this issue 2 years ago • 9 comments

  • An upgraded version of the normal suit storage unit (Same code as suit storage unit but tweaked a bit).
  • Normal suit storage can no longer clear mob radiation (not contamination) due to the lack of tech, now the advanced suit storage will do the job.

Document the changes in your pull request

  • Adds a new decontamination unit that can clear mob radiation and clearing contamination (Requires advanced engineering tech), also requires 2 cables, 5 manipulators, 5 lasers.

Can be emagged and unemagged with multitool (You can also tell if it is emagged by examining it)

emagged spoiler
  • Extend the cycle time (3->7)
  • Give mob a lot of burn damages (20, 36)
  • Increase 500 rads per cycle (3500 rads total)
  • Burn mob
  • emits radiation
  • Makes mob scream
  • When done cycling, delete everything inside except for mob and spread bad smoke
  • (Video is cropped to reduce the size)

Not emagged

https://user-images.githubusercontent.com/89688125/194802007-b74ffc6a-f276-49e4-ba98-6400bd443dcb.mp4

Emagged

https://user-images.githubusercontent.com/89688125/194802016-e279cc37-2b2c-4882-ad00-87d3a67795b1.mp4

  • Suit storage unit can no longer clear mob radiation

  • Fixes being able to open suit storage unit with alt click while panel is open

  • Fixes being able to open suit storage unit with alt click while machine is running

  • Add two ADSSU's each (Atmos and Engineering) to asteroid, box, gax and meta station

Spriting

Sprites from:

  • https://github.com/shiptest-ss13/Shiptest/pull/500
  • https://github.com/discordia-space/CEV-Eris/pull/4431 (Mostly)
  • Cuackles adjusted the sprite a bit old image

new image

Wiki Documentation

  • Adds a new decontamination unit that can clear mob radiation and clearing contamination (Requires advanced engineering tech), also requires 2 cables, 5 manipulators, 5 lasers.
  • Suit storage unit can no longer clear mob radiation
  • Fixes being able to open suit storage unit with alt click while panel is open
  • Fixes being able to open suit storage unit with alt click while machine is running
  • Add two ADSSU's each (Atmos and Engineering) to asteroid, box, gax and meta station Can be emagged and unemagged with multitool (You can also tell if it is emagged by examining it)
emagged spoiler
  • Extend the cycle time (3->7)
  • Give mob a lot of burn damages (30, 46)
  • Increase 500 rads per cycle (3500 rads total)
  • emits radiation
  • Burn mob
  • shock mob
  • Makes mob scream
  • When done cycling, delete everything inside except for mob

Changelog

:cl: Warface1234455, ACCount12 (sprites) and retlaw34 (sprites), Cuackles(sprites) rscadd: Added a new decontamination unit that can clear mob radiation and clearing contamination (Requires advanced engineering tech), also requires 2 cables, 5 manipulators, 5 lasers. rscdel: Suit storage unit can no longer clear mob radiation. bugfix: Fixed being able to open machine with alt click while panel is open for suit storage unit bugfix: Fixed being able to open suit storage unit with alt click while machine is running mapping: Added two ADSSU's each (Atmos and Engineering) to asteroid, box, gax and meta station /:cl:

warface1234455 avatar Oct 09 '22 04:10 warface1234455

Ok but can you still microwave people in them even if it doesn't clear the rads?

Mqiib avatar Oct 09 '22 06:10 Mqiib

Ok but can you still microwave people in them even if it doesn't clear the rads?

Yes

warface1234455 avatar Oct 09 '22 06:10 warface1234455

The sprite seems really unfitting.

Cartlord avatar Oct 09 '22 08:10 Cartlord

The sprite seems really unfitting.

you got better sprite then?

warface1234455 avatar Oct 10 '22 07:10 warface1234455

I'm curious why we need this & why we need to make normal storage units NOT scrub rads?

VaelophisNyx avatar Oct 12 '22 06:10 VaelophisNyx

I'm curious why we need this & why we need to make normal storage units NOT scrub rads?

I'm only removing the ability for the normal storage unit to clear mob radiation not the whole contamination clearing, the advanced one instead gets the ability to clear mob radiation

warface1234455 avatar Oct 12 '22 06:10 warface1234455

I'm curious why we need this & why we need to make normal storage units NOT scrub rads?

I'm only removing the ability for the normal storage unit to clear mob radiation not the whole contamination clearing, the advanced one instead gets the ability to clear mob radiation

But why? You are inventing the problem for your solution.

JamieD1 avatar Oct 22 '22 12:10 JamieD1

But why? You are inventing the problem for your solution.

The normal suit storage unit tech is insufficient to do the mob radiation clearing, the advanced one is more advanced and well developed so it is capable of doing so @JamieD1

warface1234455 avatar Oct 22 '22 13:10 warface1234455

Cornflakes

warface1234455 avatar Oct 22 '22 13:10 warface1234455

CORNFLAKE AGAIN

warface1234455 avatar Oct 25 '22 16:10 warface1234455

Removed map changes

warface1234455 avatar Oct 28 '22 13:10 warface1234455

But why? You are inventing the problem for your solution.

The normal suit storage unit tech is insufficient to do the mob radiation clearing, the advanced one is more advanced and well developed so it is capable of doing so @JamieD1

Yeah but the normal one can scrub radiation right now, and the sprite does look out of place.

JamieD1 avatar Oct 29 '22 13:10 JamieD1

But why? You are inventing the problem for your solution.

The normal suit storage unit tech is insufficient to do the mob radiation clearing, the advanced one is more advanced and well developed so it is capable of doing so @JamieD1

Yeah but the normal one can scrub radiation right now, and the sprite does look out of place.

Just an upgrade for it @JamieD1, the sprite does be fitting imo, Cuackless finds it the same

warface1234455 avatar Oct 29 '22 13:10 warface1234455

The old 3/4 sprite looked out of place cus it was 3/4, the current one should fit better

cuackles avatar Oct 29 '22 14:10 cuackles

unknown-35.png that's how the new one looks with the new perspective Wich makes it fit more, if you still have an issue with it the coloring could also be changed to a duller boring color so it pops less into view

cuackles avatar Oct 29 '22 14:10 cuackles

@JamieD1 ^^^

warface1234455 avatar Oct 29 '22 14:10 warface1234455

welp Jamie said it's a different art style and still does look out of place, i will have to remove it now :(

warface1234455 avatar Oct 31 '22 12:10 warface1234455

But why? You are inventing the problem for your solution.

The normal suit storage unit tech is insufficient to do the mob radiation clearing, the advanced one is more advanced and well developed so it is capable of doing so @JamieD1

Yeah but the normal one can scrub radiation right now, and the sprite does look out of place.

This still doesn't scrub radiation from mobs, does it?

ReddicusDragon avatar Nov 07 '22 20:11 ReddicusDragon

This still doesn't scrub radiation from mobs, does it?

Nope, still does

warface1234455 avatar Nov 08 '22 01:11 warface1234455

I’m a bit confused here can someone help me out, we are removing the ability to scrub rads from the normal one? But there will be a advance one to cover up for it?

KillerOrcaCora avatar Nov 08 '22 01:11 KillerOrcaCora

I’m a bit confused here can someone help me out, we are removing the ability to scrub rads from the normal one? But there will be a advance one to cover up for it?

No, its still the same i removed the advanced one because the sprite is unfitting

warface1234455 avatar Nov 08 '22 01:11 warface1234455

DM me the png of the sprite Jamie and cuackles said was out of place, if you still want to go that route that is and I could make you something better

KillerOrcaCora avatar Nov 08 '22 01:11 KillerOrcaCora

DM me the png of the sprite Jamie and cuackles said was out of place, if you still want to go that route that is and I could make you something better

Drafted untill @KillerOrcaCora makes better sprite

warface1234455 avatar Nov 08 '22 06:11 warface1234455

Can you reopen this when orca makes a better sprite, puts it further up the queue

TheGamerdk avatar Nov 08 '22 17:11 TheGamerdk

ya

warface1234455 avatar Nov 09 '22 00:11 warface1234455