Yogstation icon indicating copy to clipboard operation
Yogstation copied to clipboard

[PORT] Crew monitor new icons

Open warface1234455 opened this issue 2 years ago • 13 comments

About PR

Ports:

  • https://github.com/Skyrat-SS13/Skyrat-tg/pull/12744
  • https://github.com/Skyrat-SS13/Skyrat-tg/pull/12147

Document the changes in your pull request

Tweaked colors a bit and added some icons New health icon status and race icons Any other races will showed as red mark Suit sensors now check your species and if you are on fire, irradiated, wounded, husked image image from left to right: irradiated(500 rad and above), husked(If reaches 241 burn damage), on fire, wounded(Bone crack, etc..), species, vitals

Wiki Documentation

Crew monitor has new health status and race icons

Changelog

:cl: Zergspower, Deek-Za ported by warface1234455 (Also added a few things) rscadd: suit sensor now check your race and if you have wound, husk, on fire and irradiation imageadd: replaced old color box icons with new health status icons for crew monitor imageadd: added some health check icons for wound, husk, on fire and irradiation imageadd: added some race icons /:cl:

warface1234455 avatar Aug 13 '22 08:08 warface1234455

why lints failed aaa imma go rice and figure this later

warface1234455 avatar Aug 13 '22 08:08 warface1234455

White forgor skeleton because you really are just gonna be forgotten

KillerOrcaCora avatar Aug 13 '22 08:08 KillerOrcaCora

White forgor skeleton because you really are just gonna be forgotten

What

warface1234455 avatar Aug 13 '22 08:08 warface1234455

why lints failed aaa imma go rice and figure this later

/home/runner/work/Yogstation/Yogstation/tgui/packages/tgui/interfaces/CrewConsole.js 2:49 error A space is required before '}' object-curly-spacing 57:1 error This line has a length of 104. Maximum allowed is 100 max-len 152:1 error Expected indentation of 18 spaces but found 16 indent 152:17 error Expected indentation of 18 space characters but found 16 react/jsx-indent 153:1 error Expected indentation of 20 spaces but found 18 indent 154:1 error Expected indentation of 22 spaces but found 20 indent 155:1 error Expected indentation of 24 spaces but found 22 indent 156:1 error Expected indentation of 24 spaces but found 22 indent 157:1 error Expected indentation of 24 spaces but found 22 indent 158:1 error Expected indentation of 24 spaces but found 22 indent 159:1 error Expected indentation of 24 spaces but found 22 indent 160:1 error Expected indentation of 24 spaces but found 22 indent 161:1 error Expected indentation of 22 spaces but found 20 indent 162:1 error Expected indentation of 24 spaces but found 22 indent 163:1 error Expected indentation of 24 spaces but found 22 indent 164:1 error Expected indentation of 24 spaces but found 22 indent 165:1 error Expected indentation of 24 spaces but found 22 indent 166:1 error Expected indentation of 24 spaces but found 22 indent 167:1 error Expected indentation of 24 spaces but found 22 indent 168:1 error Expected indentation of 22 spaces but found 20 indent 169:1 error Expected indentation of 18 spaces but found 16 indent 170:1 error Expected indentation of 20 spaces but found 18 indent 171:1 error Expected indentation of 22 spaces but found 20 indent 172:1 error Expected indentation of 20 spaces but found 18 indent 173:1 error Expected indentation of 22 spaces but found 20 indent 174:1 error Expected indentation of 20 spaces but found 16 indent

✖ 26 problems (26 errors, 0 warnings) 25 errors and 0 warnings potentially fixable with the --fix option.

ghost avatar Aug 13 '22 08:08 ghost

I can see

warface1234455 avatar Aug 13 '22 08:08 warface1234455

ok fixing lints broke the computer

warface1234455 avatar Aug 13 '22 09:08 warface1234455

my life is a pain

warface1234455 avatar Aug 13 '22 10:08 warface1234455

imma add some race icons

warface1234455 avatar Aug 14 '22 17:08 warface1234455

Is there no way to make the map work again?

JamieD1 avatar Aug 20 '22 12:08 JamieD1

Is there no way to make the map work again?

^

JamieD1 avatar Aug 28 '22 14:08 JamieD1

idk anything about the old map, i didnt even get to see it

warface1234455 avatar Aug 28 '22 14:08 warface1234455

Code quality poopoo, review soon

i have less knowledge in coding so im basically just porting stuffs but i do test it to make sure everything works

warface1234455 avatar Aug 28 '22 14:08 warface1234455

Code quality poopoo, review soon

i have less knowledge in coding so im basically just porting stuffs but i do test it to make sure everything works

it is ok, that is why we have maintainers

TheGamerdk avatar Aug 28 '22 16:08 TheGamerdk

@TheGamerdk Get on it please.

JamieD1 avatar Sep 04 '22 12:09 JamieD1

for the love of god fix the code Can you suggest fixes?

JamieD1 avatar Sep 17 '22 11:09 JamieD1

for the love of god fix the code Can you suggest fixes?

see my initial review comment

redmoogle avatar Sep 17 '22 11:09 redmoogle

~~Im in hospital probably gonna stay there for a week~~ got discharged currently working on it

warface1234455 avatar Sep 18 '22 03:09 warface1234455

done @JamieD1

warface1234455 avatar Sep 21 '22 10:09 warface1234455

@TheGamerdk review

warface1234455 avatar Sep 21 '22 11:09 warface1234455

ok lemme fix the thing CHIULL

warface1234455 avatar Sep 21 '22 11:09 warface1234455

done and done pls review :(

warface1234455 avatar Sep 23 '22 15:09 warface1234455

what you can't request two people?? brah github, since jamie is on break sooo

warface1234455 avatar Sep 30 '22 06:09 warface1234455