KeyPass icon indicating copy to clipboard operation
KeyPass copied to clipboard

Published 20 hours ago • verified publisher icon yogeshpaliyal

Migrate to Jetpack Compose

Open yogeshpaliyal opened this issue 3 years ago • 6 comments

yogeshpaliyal avatar Oct 26 '21 03:10 yogeshpaliyal

Hello what is your preferred strategy to accomplish this?

t-regbs avatar Mar 16 '22 14:03 t-regbs

@t-regbs haven't get enough time to work in this

yogeshpaliyal avatar Mar 16 '22 15:03 yogeshpaliyal

I would like to work on it. I wanted to know how exactly you prefer to do it. Maybe migrating parts of the app to compose gradually (eg. screen by screen)? But then I can see a keypasscompose module, was wondering what your plan was with that?

t-regbs avatar Mar 16 '22 15:03 t-regbs

Yeah, so actual plan is to keep app in both frameworks

yogeshpaliyal avatar Mar 16 '22 16:03 yogeshpaliyal

ok I see with a shared common module what would you suggest todo first?

t-regbs avatar Mar 18 '22 19:03 t-regbs

Shared common module contains all the logic, except for the UI, that can be used with both XML and compose.

yogeshpaliyal avatar Mar 19 '22 05:03 yogeshpaliyal

What is the name of the stable branch for compose?

5AbhishekSaxena avatar Jan 16 '23 17:01 5AbhishekSaxena

composeUpdate branch

yogeshpaliyal avatar Jan 16 '23 17:01 yogeshpaliyal

Do you have any plans for the migration?

5AbhishekSaxena avatar Jan 16 '23 19:01 5AbhishekSaxena

@5AbhishekSaxena no there is no plan as such, we can go screen by screen, first homepage, then add account page.

yogeshpaliyal avatar Jan 17 '23 03:01 yogeshpaliyal

@yogeshpaliyal cool, let's create the issues and start working.

5AbhishekSaxena avatar Jan 17 '23 05:01 5AbhishekSaxena

Why do you have a separate module for Compose?

5AbhishekSaxena avatar Jan 17 '23 21:01 5AbhishekSaxena

Because I don't want to break the App while we migrate to XML and also we can keep XML module so others can go through code of XML and Compose both.

yogeshpaliyal avatar Jan 18 '23 05:01 yogeshpaliyal

You can have compose code in xml and vice versa and it won't break anything as it is built that way.

You can refer to the official documentation for more information. Link: https://developer.android.com/jetpack/compose/interop/migration-strategy

I have also written an article on the migration that you can refer to as well. Link: https://proandroiddev.com/migration-to-jetpack-compose-for-a-legacy-application-3bf256df2ebe

5AbhishekSaxena avatar Jan 18 '23 05:01 5AbhishekSaxena

Yes I am aware of that but I want to keep both the apps, we can do one thing in compose we can copy xml code and then migrate this to compose.

yogeshpaliyal avatar Jan 18 '23 05:01 yogeshpaliyal

Okay. It would be great if you could do the basic setup to begin the migration.

5AbhishekSaxena avatar Jan 18 '23 16:01 5AbhishekSaxena

Sure I will do the basic setup

yogeshpaliyal avatar Jan 18 '23 17:01 yogeshpaliyal

basic setup done for compose module

yogeshpaliyal avatar Jan 18 '23 18:01 yogeshpaliyal