rengine
rengine copied to clipboard
not exposing unecessary containers publicly
postgres and the internal container shouldn't be exposed publicly, only the reverse proxy should.
I can still see the ports being exposed. I think it is better to remove ports at all for db right?
Yes you can on 127.0.0.1:8000 but it will not be exposed on all interfaces (0.0.0.0) as by default, this is especially important on VPS.
With reNgine being exposed only on localhost, it doesn't change anything for people having it installed on their machine, and for people installing it on a VPS they can expose it via a SSH tunnel or setup a reverse-proxy with client certificate authentication rather than having it exposed directly over internet.
What do we do with this PR?
We could restrict port to 127.0.0.1 only
We could restrict port to 127.0.0.1 only
What do you mean? That's happening with this PR.
We could restrict port to 127.0.0.1 only
What do you mean? That's happening with this PR.
I mean, go merging this one
This needs 2 more approvals before I can merge though. :)
What about https://github.com/yogeshojha/rengine/blob/master/docker-compose.dev.yml btw? Doesn't it need to be applied there?