WebCrawlerTokopedia icon indicating copy to clipboard operation
WebCrawlerTokopedia copied to clipboard

Reuse buffers using sync.Pool

Open GaruGaru opened this issue 5 years ago • 2 comments

Reference #3 Using the go stdlib object pool instead of creating new buffer instances should reduce memory usage and improve GC latency

GaruGaru avatar Oct 10 '19 18:10 GaruGaru

Hi @GaruGaru Could you please compare previous working and your changes in terms of benchmarking? Like how the memory usage, GC latency is being better? That will help a lot Thank you.

yogesh-desai avatar Oct 11 '19 07:10 yogesh-desai

Hi @yogesh-desai Sadly i didn't manage to run the application property because chromedp package just deprecated its package chromedp/runner in the latest version and also the package is now pointing to a new repo ( https://github.com/chromedp/chromedp ). In order to run the application i need the version of chromedp that you have locally, also a properly versioned packaged manager (such as go modules or dep) may be needed to avoid this kind of reproducibility issues

Thank you for your time !

GaruGaru avatar Oct 11 '19 10:10 GaruGaru