fxphp icon indicating copy to clipboard operation
fxphp copied to clipboard

Constructor changes for PHP7+ compatibility

Open APD183 opened this issue 8 years ago • 6 comments

Dipping my toes in PHP 7, it looks like FX.php needs some changes to its function constructors to operate error-free and continue to work for future versions. I can submit some changes later, but just wanted to point it out in case someone else has the time to submit changes.

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; FX has a deprecated constructor in C:\inetpub\www_test\html\includes\FX\FX.php on line 55

APD183 avatar Jun 22 '16 02:06 APD183

Yep, one of the points of that development branch is to get FX.php all clean and modernized. Things have been kinda crazy for me for a while, but I also wouldn't mind if someone(s) had time to help on this. Documentation is also getting a really nice update.

yodarunamok avatar Jun 22 '16 12:06 yodarunamok

What's the lowest version of PHP you're targeting for backward compatibility?

APD183 avatar Jun 23 '16 00:06 APD183

There really needs to be another branch for this, as I'm still hoping to update things for people with older installs. That said, PHP 5.3 would be nice, though I could be persuaded to use an even more recent version if there were a compelling reason.

yodarunamok avatar Jul 09 '16 21:07 yodarunamok

I just tried to upgrade to PHP 7.1 and I saw the same issues with the OO class constructors. Is there any update on when a compatible FX will be available? (By the way, thank you for keeping this code for everyone). If it helps, our institution is willing to test the code.

LRCUSUHS avatar Dec 21 '16 13:12 LRCUSUHS

Okay, just created branches called legacy and legacy-develop from master which will be used for future fixes (as needed) for the old release. I also created a release based on the current state of master for easy download (version 6.10). From this point on, I'll be doing active development on the master branch based on compatibility with PHP7.

yodarunamok avatar Mar 11 '17 23:03 yodarunamok

Hi There!

I apologize if I'm missing something obvious, but, is there a version of FX that works with PHP 7+? I see that there was an intent to do so, but, it's not clear from the ReadMe.md, nor the branches, that FX is PHP 7+ ready yet.

Thanks!

rjakes avatar May 30 '18 19:05 rjakes