ShadowNode Best practice of building with dependencies

Best practice of building with dependencies

Open legendecas opened this issue 5 years ago • 4 comments

We should document the best practice of building on macOS with dbus installed with brew.

As pkg-config could find dbus related stuff: https://github.com/yodaos-project/ShadowNode/blob/master/cmake/iotjs.cmake#L405-L407

It might be much more convenient to brew install pkg-config then build.

Oct 08 '19 07:10 legendecas

btw, it seems that dbus is useless, should we remove it to make building easier ?

Oct 10 '19 13:10 qile222

Yes, dbus module could be disabled by default.

Oct 10 '19 13:10 legendecas

Still, building with pkg-config would be the be best practice if there are any system dependencies.

Oct 10 '19 16:10 legendecas

+1 on disable dbus by default

Oct 11 '19 04:10 yorkie