Improve tests

[manparvesh]

Description:

The existing tests are okay, but not very thorough. Some of the parts of the modules still lack tests.

Checklist:

• [x] learn
  • [x] flashcards
• [ ] life
  • [ ] reading list
  • [ ] ideas
• [ ] setup

Related to: #16

[ybfe1853]

Hello, I am writing some test cases for the flashcard functionality, but i have a question. Namely with the naming of the sets:

If I try to give the set a name with length of characters larger than 1, i get the error 'the length of the name should not be more than 1', is this the intended functionality? sets cannot have names longer than 1 character? After playing around with the modify function is doesn't seem that this was intended.

[ybfe1853]

Also if it so happens that changed need to be made to the source code, should i open up separate pull requests for the test cases and the actual source code being changed?

[manparvesh]

@ybfe1853

If I try to give the set a name with length of characters larger than 1, i get the error 'the length of the name should not be more than 1', is this the intended functionality?

I don't recall setting any limit like that :thinking:

Also if it so happens that changed need to be made to the source code, should i open up separate pull requests for the test cases and the actual source code being changed?

If you mean that you want to create a new PR for the fix for restoring the length of set name, then yes. Also, please create an issue with some more details of whatever you found in that issue.

[prideloki]

Hi @manparvesh, i would like to contribute on testing ideas feature.

[manparvesh]

@prideloki Sure! I'd be glad to review your PR!