yoda icon indicating copy to clipboard operation
yoda copied to clipboard

[WIP] Refactoring/dry

Open mondaini opened this issue 5 years ago • 3 comments

Short description of what this resolves: Fixing some DRY violations

Fixes: #223

mondaini avatar Oct 27 '18 14:10 mondaini

@mondaini I merged your other PR and it seems that your fork is not updated. Please update it and resolve the merge conflicts.

manparvesh avatar Oct 29 '18 10:10 manparvesh

No problem @manparvesh :-)

There are other DRY violations I found that I intend to fix. I believe that the project's Coverage will improve after these changes.

mondaini avatar Oct 29 '18 16:10 mondaini

Codecov Report

Merging #224 into master will decrease coverage by 4.55%. The diff coverage is 62.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   76.37%   71.81%   -4.56%     
==========================================
  Files          59       55       -4     
  Lines        3357     3151     -206     
==========================================
- Hits         2564     2263     -301     
- Misses        793      888      +95
Impacted Files Coverage Δ
resources/hackerearth/result.py 100% <ø> (ø) :arrow_up:
setup.py 100% <ø> (ø) :arrow_up:
resources/hackerearth/language.py 100% <ø> (ø) :arrow_up:
modules/__init__.py 100% <ø> (ø) :arrow_up:
tests/test_chat.py 100% <100%> (ø) :arrow_up:
tests/dev/test_whois.py 100% <100%> (ø) :arrow_up:
tests/test_weather.py 95.23% <100%> (ø) :arrow_up:
tests/test_asciiator.py 100% <100%> (ø) :arrow_up:
tests/test_goals.py 100% <100%> (ø) :arrow_up:
tests/life/test_rlist.py 100% <100%> (ø) :arrow_up:
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e8b3e4...1b24024. Read the comment docs.

codecov-io avatar Oct 29 '18 17:10 codecov-io