yoda
yoda copied to clipboard
[WIP] Refactoring/dry
Short description of what this resolves: Fixing some DRY violations
Fixes: #223
@mondaini I merged your other PR and it seems that your fork is not updated. Please update it and resolve the merge conflicts.
No problem @manparvesh :-)
There are other DRY violations I found that I intend to fix. I believe that the project's Coverage will improve after these changes.
Codecov Report
Merging #224 into master will decrease coverage by
4.55%
. The diff coverage is62.1%
.
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
- Coverage 76.37% 71.81% -4.56%
==========================================
Files 59 55 -4
Lines 3357 3151 -206
==========================================
- Hits 2564 2263 -301
- Misses 793 888 +95
Impacted Files | Coverage Δ | |
---|---|---|
resources/hackerearth/result.py | 100% <ø> (ø) |
:arrow_up: |
setup.py | 100% <ø> (ø) |
:arrow_up: |
resources/hackerearth/language.py | 100% <ø> (ø) |
:arrow_up: |
modules/__init__.py | 100% <ø> (ø) |
:arrow_up: |
tests/test_chat.py | 100% <100%> (ø) |
:arrow_up: |
tests/dev/test_whois.py | 100% <100%> (ø) |
:arrow_up: |
tests/test_weather.py | 95.23% <100%> (ø) |
:arrow_up: |
tests/test_asciiator.py | 100% <100%> (ø) |
:arrow_up: |
tests/test_goals.py | 100% <100%> (ø) |
:arrow_up: |
tests/life/test_rlist.py | 100% <100%> (ø) |
:arrow_up: |
... and 82 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6e8b3e4...1b24024. Read the comment docs.