yoda icon indicating copy to clipboard operation
yoda copied to clipboard

adding sms feature, and python-dbus dependency

Open skymoore opened this issue 5 years ago • 3 comments

Short description of what this resolves:

Adds the ability for yoda to use your kdeconnect connected smart phone to send an sms to a friend registered in the people config file.

Changes proposed in this pull request:

+add people sms feature +add python-dbus dependency

skymoore avatar Oct 16 '18 05:10 skymoore

Codecov Report

Merging #201 into master will decrease coverage by 58.88%. The diff coverage is 1.19%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #201       +/-   ##
===========================================
- Coverage   76.37%   17.48%   -58.89%     
===========================================
  Files          59       44       -15     
  Lines        3357     2882      -475     
===========================================
- Hits         2564      504     -2060     
- Misses        793     2378     +1585
Impacted Files Coverage Δ
yoda.py 3.33% <ø> (-89.47%) :arrow_down:
tests/test_people.py 8.82% <0%> (-91.18%) :arrow_down:
modules/people.py 3.04% <1.25%> (-90.8%) :arrow_down:
tests/test_diary.py 6.52% <0%> (-93.48%) :arrow_down:
tests/learn/test_flashcards.py 10.52% <0%> (-89.48%) :arrow_down:
tests/test_love.py 11.53% <0%> (-88.47%) :arrow_down:
tests/test_goals.py 13.63% <0%> (-86.37%) :arrow_down:
tests/dev/test_grep.py 13.79% <0%> (-86.21%) :arrow_down:
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e8b3e4...3392314. Read the comment docs.

codecov-io avatar Oct 16 '18 06:10 codecov-io

image check fails with:

File "/home/travis/build/yoda-pa/yoda/modules/people.py", line 7, in <module>
    import dbus
ModuleNotFoundError: No module named 'dbus'

Obviously python-dbus and python3-dbus are valid packages that can be used by importing them with

import dbus

as can be seen by my screenshot, or by installing the package/s on your distro and running my code. Must be a travis issue? @manparvesh any input on how to get this to pass would be great.

skymoore avatar Oct 16 '18 06:10 skymoore

@mskymoore sorry for late reply. Regarding dbus, can you try adding libdbus-glib-1-dev to the installation script? Taken from this comment. I found no solid fix regarding this on the internet either.

manparvesh avatar Oct 20 '18 02:10 manparvesh

@manparvesh did this repo get unarchived?

skymoore avatar Apr 04 '23 15:04 skymoore

@skymoore yes I unarchived it a few days ago.

manparvesh avatar Apr 10 '23 02:04 manparvesh

@skymoore yes I unarchived it a few days ago.

@manparvesh What's the plan?

skymoore avatar Apr 11 '23 15:04 skymoore

@manparvesh you're going to integrate it with chatgpt huh?

skymoore avatar Apr 11 '23 15:04 skymoore