contra

Results 298 comments of contra

I left a comment on one of your other PRs - please don't open any additional ones until we resolve this: https://github.com/hparra/gulp-rename/pull/94#issuecomment-746906407

Not sure I understand the issue, could you elaborate or provide a smaller more focused code sample? The cache should be placed before any transformations so they only get executed...

@DaveyJake Can you create a github repo that reproduces the issue?

@DaveyJake Yeah, it would help us to debug if you can make a standalone github repo that reproduces the issue - without that there isn't much we can help with.

If this module was somehow causing a segfault it would be a node bug because the JS for this plugin is pretty simple

Is this with concat or gulp itself?

@billrawlinson Can you try just piping src to dest a bunch of times and see if that causes the issue as well?

I'm guessing it has something to do with buffer conversions in concat-with-sourcemaps: - https://github.com/floridoo/concat-with-sourcemaps/blob/master/index.js#L109 - https://github.com/floridoo/concat-with-sourcemaps/blob/master/index.js#L43-L46 - https://github.com/floridoo/concat-with-sourcemaps/blob/master/index.js#L15-L18 Probably mixing a bunch of encodings together using node's Buffer module is...

@billrawlinson I mean that the separator is treated as UTF-8, so combining that with some UTF-16 buffers might be yielding weird results

@billrawlinson Hmm trying to think up a solution here, going to dig into the buffer docs and see if I can figure something out