Yoshikuni Kato
Yoshikuni Kato
@hojberg The infinite fetch happens after this change. I'm testing local-ui with ui-core on this branch.
I found the reason for the loop request: With new logic, it makes `Reference`s of new items in `workspaceItems` based on the API **response**. A reference used for **request** (and...
It seems to make sense to make references based on the API response for items in `workspaceItems`, as API might response with multiple items for one request (not handling this...
One of the potential issues might be here in local-ui: https://github.com/unisonweb/unison-local-ui/blob/main/src/UnisonLocal/Page/CodePage.elm#L131-L137 Regardless of the Msg sent, it's calling `updateSubpage`, leading to the call of `Workspace.open`. It might be better to...
This is where reference is constructed based on API response https://github.com/unisonweb/ui-core/pull/90#discussion_r1621271414
Working on this issue, might take a bit more
Fixed loop fetch issue with a different approach!
I cleaned some decoding logic for clarity. Also, can you check this PR on ui-core-scripts too? I've already been using this, but it's helpful to debug ui-core changes with local-ui....
@hojberg It seems UI.Switch is not used anymore, which triggers the Elm review error on CI. Is it ok to remove it from codebase?
Hello. I've removed UI.Switch. I think it's ready for review. I also have an open PR here: https://github.com/unisonweb/ui-core-scripts/pull/2, but it seems local-ui doesn't work with latest ui-core anymore?