FavCat-Restored icon indicating copy to clipboard operation
FavCat-Restored copied to clipboard

[BUG] Avatar sniffer not capturing seen avatars

Open HeyImRuu opened this issue 2 years ago • 0 comments

Describe the bug

basically same as #3 5a01d26 fixed worlds not being sniffed, but now seen avatars are not being sniffed. Changing line 250 of FavCatMod.cs back to == typeof(Il2CppSystem.Object) sniffs avatars but not worlds. What i think is happening: Im assuming seen avatars in a world uses: public bool SetApiFieldsFromJson(IReadOnlyDictionary<string, Il2CppSystem.Object> fields); overload of SetApiFieldsFromJson and worlds uses: public bool SetApiFieldsFromJson(IReadOnlyDictionary<string, Json.Token> fields); as only one of those overloads gets hooked we're missing either seen avatars or worlds.

Adding the avatar to fav via the quick menu adds it to the db but not to the fav list, unless you add it again.

Screenshots

1.1.19 behaviour - see new public avatar, search for avatar from authors page "Show known public avatars" button - avatar not added annotated search new sniffed avatar

Errors

Questions:

  • Are you using the latest version of FavCatRestored?: 1.1.19
  • Are you using the latest version of UIX?: 1.0.2
  • Does the issue happen if you only use FavCatRestored & UIX? Y
  • Are you using the latest version of MelonLoader?: 0.5.4

MelonLoader log

[15:11:26.996] [FavCatRestored] Local search done, 4086 results - searching all in db [15:11:43.960] [FavCatRestored] Local search done, 0 results - viewing public avatars for user who's public avatar is new to me [15:11:51.223] [FavCatRestored] Local search done, 4086 results - searching all again in db, no new avatars

HeyImRuu avatar Jun 21 '22 06:06 HeyImRuu