nipplejs icon indicating copy to clipboard operation
nipplejs copied to clipboard

fix: use transform translate for nipple front

Open MCArth opened this issue 2 years ago • 2 comments

As discussed in https://github.com/yoannmoinet/nipplejs/issues/168, this uses transform: translate instead of setting top/left on the nipple front.

Two notes that might be worth their own issue:

The npm prepare script runs on npm install, and setting NODE_ENV fails on windows. I'd personally prefer cross-env for something like this. Also, 6 of the tests fail without any of my changes? 6 still fail with them.

MCArth avatar May 11 '22 15:05 MCArth

If I read the code correctly, I also think if (opts.follow) { should be if (opts.follow && !opts.dataOnly) { here

MCArth avatar May 11 '22 15:05 MCArth

Thanks for this, I'll have a look asap.

yoannmoinet avatar May 11 '22 18:05 yoannmoinet

Any chance we could revive this PR and make it happen? :) I'm also seeing some significant FPS drop when moving the joystick.

verekia avatar Oct 10 '22 10:10 verekia

@verekia I've been using this branch in production since I made this PR and it seems stable, you could depend directly on it until @yoannmoinet deals with the pr

MCArth avatar Oct 10 '22 10:10 MCArth

Hey sorry about that, thanks for the new ping. I'll get to it :D

yoannmoinet avatar Oct 10 '22 11:10 yoannmoinet

Published in v0.10.0 Thanks a ton :bow:

yoannmoinet avatar Oct 10 '22 12:10 yoannmoinet

Thanks a lot to you both!

verekia avatar Oct 10 '22 13:10 verekia