ayon-launcher icon indicating copy to clipboard operation
ayon-launcher copied to clipboard

Enhancement: Use dataclasses instead of attrs

Open iLLiCiTiT opened this issue 1 year ago • 3 comments

Description

This was a suggestion, that we should replace attrs in distribution logic with dataclasses. I've personally never used them yet so I'm not sure how much work it is, but it looks similar with datatype checks.

iLLiCiTiT avatar Jun 30 '23 13:06 iLLiCiTiT

Any reason why it was recommended one over the other? Would we get certain benefits from doing the change?

BigRoy avatar Mar 09 '24 09:03 BigRoy

Would we get certain benefits from doing the change?

Well, dataclasses is built-in python module with direct typehint support, whereas attrs is added dependency without simple typehinting.

iLLiCiTiT avatar Mar 11 '24 10:03 iLLiCiTiT

Good enough for me! :)

BigRoy avatar Mar 11 '24 10:03 BigRoy