Attributes page make commiting save clearer

[mkolar]

I've been caught out a few time already after creating a new attribute only to then realize that it's nowhere to be found. turns out you have to confirm the attribute creation twice.

1. on the actual modal during it's creation
2. On the Attributes page again.

Even though it is nice I can make multiple attributes, check if everything is ok and only then commit them all to the database, I have to say that we probably overdid it here with the safety mechanism.

Proposal:

I'd completely remove the button about saving attribute changes from the attributes page. Or have it commit automatically when confirming the modal

[martastain]

There's also the thing that save button also confirms the ordering. It is easy to reorder attributes by mistake so it shouldn't commit whenever you do that.

[BigRoy]

I'd completely remove the button about saving attribute changes from the attributes page. Or have it commit automatically when confirming the modal

There's also the thing that save button also confirms the ordering. It is easy to reorder attributes by mistake so it shouldn't commit whenever you do that.

I wouldn't expect it to suddenly 'save' any other changes I might have been making locally that were still unsaved - so like @martastain describes, I wouldn't just force commit it on Create attribute.

Not sure if changing the label from "Create attribute" to "Add attribute" may somewhat help the idea that it's not automatically creating it?

Also I would've expected that full line for the new unsaved attribute to be bright blue, similar to unsaved changes in the Project Editor. But now it just appears selected and then I agree, it does look "saved" already compared to other editors maybe?

[Innders]

• [ ] Label "Create attribute" to "Add attribute"
• [ ] Highlight new unsaved attributes like in editor.

[m-u-r-p-h-y]

I completely agree with @mkolar on this. This requirement of double saving caused me to lose my work, forgetting I have to Save the changes after using Save attribute.

So if we keep the label Save attribute, we should remove Save changes and commit with the first Save

I do not agree with @martastain on random order changes. maybe with a tablet. The issue I can see here, that the Save button indicates that there are changes to save even if you did not do any change. So if it only will be active with any change you will know that you did something and you do not need to Save.

At the same time we are missing Cancel button, because the way we can close the window by clicking anywhere outside of it is even more dangerous as I lost so many changes by accidently clicking outside

[mkolar]

I've hit this multiple times and even though it's and old issue I agree it still applies. You have to create them one by one anyway, so there's little merit to having two saves in a row

[martastain]

Those are not "two saves" .... Maybe the button could be just labeled "OK" instead Save. because the actual save happens when the entire list is submitted (which triggers "server restart required" state and not restarting could in edge cases put multiple replicas off sync).

Leaving the page with unsaved changes should raise a warning.