ayon-core icon indicating copy to clipboard operation
ayon-core copied to clipboard

Enhancement: Highlight pre-handle, cut, and post-handle in review overlays

Open BigRoy opened this issue 1 year ago • 5 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

The creation of reviews currently performs a burnin overlay - by default something like this:

image

It'd be nice if the overlay could highlight what frames of the video are "pre-handle", "cut" or "post-handle" and highlight that handle label + the frame range in a different color for frame ranges outside of the main frames.

Without that information when seeing just the video file or the video with overlay in an edit it provides no information as to what was considered to be the original cut and what was considered to be handles.

A design example could be: precut_example

The above example image uses pre-cut as example text but maybe pre-handles might be clearer

How would you imagine the implementation of the feature?

A special burnin label {handles_label} or alike can be added to burnins which will act like:

  • pre-handle: Frames before the frameStart
  • cut: Frames including and between frameStart - frameEnd
  • post-handle: Frames after the frameEnd.

Since the burnin formattin data needs to be per frame we likely need to do something like this:

Pseudocode:

def get_frame_label(frame, frame_start, frame_end):
    if frame < frame_start:
        return "pre-handle"
    if frame > frame_end:
        return "post-handle"
    return "cut"
        
frame_start_handle = 1000
frame_start = 1003
frame_end = 1006
frame_end_handle = 1009
frame_labels = [get_frame_label(frame, frame_start, frame_end) for frame in range(frame_start_handle, frame_end_handle+1)]
print(frame_labels)
# ['pre-handle', 'pre-handle', 'pre-handle', 'cut', 'cut', 'cut', 'cut', 'post-handle', 'post-handle', 'post-handle']

For the recoloring of certain texts pre, during and post handles we might need to get another customizable setting out there. What the best user-friendly setting is for that I'll leave up for discussion.

Are there any labels you wish to add?

  • [X] I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

No response

[cuID:OP-6942]

BigRoy avatar Sep 25 '23 18:09 BigRoy