ayon-core icon indicating copy to clipboard operation
ayon-core copied to clipboard

Refactor: Hacky render frames/handles management caused by Harmony

Open Tilix4 opened this issue 6 months ago • 4 comments

Changelog Description

Refactor of hacky render frames/handles management due to AYON's Harmony implementation.

Additional info

Dropped ignoreFrameHandleCheck which was a exception for Harmony.

Made when working on but not required: https://github.com/ynput/ayon-harmony/pull/50

Testing notes:

  1. Regular render publish

Tilix4 avatar May 22 '25 12:05 Tilix4

If I get it correctly, this is not mandatory change? Harmony PR https://github.com/ynput/ayon-harmony/pull/50 makes possible that we can remove this, but it would work even without this PR.

If that's the case then we should wait for the harmony PR to be merged and released and bump compatible version of harmony to that released version.

iLLiCiTiT avatar May 27 '25 07:05 iLLiCiTiT

If I get it correctly, this is not mandatory change?

In fact no it isn't, you're right. I've tested it and each change completes without the other one being required. You can merge and release without caring about it.

Tilix4 avatar May 27 '25 08:05 Tilix4

In fact no it isn't, you're right. I've tested it and each change completes without the other one being required. You can merge and release without caring about it.

So merging this PR won't break older harmony addon versions?

iLLiCiTiT avatar May 27 '25 08:05 iLLiCiTiT

So merging this PR won't break older harmony addon versions?

That's what I ended up with my tests, but you cannot rely only on my words, another person has to give it a try.

Tilix4 avatar May 27 '25 09:05 Tilix4