ayon-core icon indicating copy to clipboard operation
ayon-core copied to clipboard

Default render product name profile is not unique for each AOV

Open MustafaJafar opened this issue 8 months ago • 3 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues

Current Behavior:

the default value {product[type]}{Task[name]}{Variant} doesn't consider AOVs.

Expected Behavior:

it should be {product[type]}{Task[name]}{Variant}<_{Aov}>

Version

1.0.14

What platform you are running on?

Windows

Steps To Reproduce:

  1. keep default settings value
  2. setup scene with AOV
  3. render fails becasue instnaces are not unique.

Are there any labels you wish to add?

  • [x] I have added the relevant labels to the bug report.

Relevant log output:


Additional context:

I don't know if AOV key is implement in different integration addons however, using using optional brackets should be safe <_{Aov}>

MustafaJafar avatar Apr 15 '25 16:04 MustafaJafar

I feel like this is very specific to a certain integration, because I've not seeing this in e.g. Fusion or Maya? The issue does not mention the exact reproducable case (e.g. which DCC/integration) this was reproducable with but I can render separate AOVs just fine from Maya for example.

BigRoy avatar Apr 15 '25 19:04 BigRoy

I feel like this is very specific to a certain integration, because I've not seeing this in e.g. Fusion or Maya? The issue does not mention the exact reproducable case (e.g. which DCC/integration) this was reproducable with but I can render separate AOVs just fine from Maya for example.

I didn't know that creating render instnaces is not consistent across different DCC addons.

How aov creation is handled in maya? becasue this template {product[type]}{Task[name]}{Variant} doesn't consider aovs. therefore, if my original render instance in Houdini has name renderHoudiniTest then its beauty and P aovs get renderHoudiniTest too. however, using {product[type]}{Task[name]}{Variant}<_{Aov}> results in renderHoudiniTest_Beauty and renderHoudiniTest_P respectivly.

MustafaJafar avatar Apr 16 '25 16:04 MustafaJafar

the story is like this:

Long time ago, render product names were hardcoded in the most ugly way, noone could change them. Then, brave developer came upon request of the client king and decided that evil hardcoded product names should be banished to the deepest levels of hell, so he introduced new keys to the magical product name templates so they could be finally used as gods designed them. With that, additional keys were forged for mystical anatomy templates so even paths could be embeded with the knowledge of render elements and render layers. How joyful and wonderful world would that be. But them came various backwards looking sceptics. It was decided that this is too radical change - that for already existing projects it would be too late, to much effort to set the new product name templates and so with heavy heart and gloom in the soul this option was introduced and it's default value was set to final and definitive True:

ayon+settings://core/tools/creator/use_legacy_product_names_for_renders

With that, no changes were ever made, no new tokens used and everything was as before. Dark, hardcoded, ugly.

More related stories: https://github.com/ynput/ayon-core/pull/841 https://github.com/ynput/ayon-houdini/pull/67

antirotor avatar Apr 16 '25 22:04 antirotor

Has this been resolved since, or what's still needed?

BigRoy avatar Jul 03 '25 20:07 BigRoy