ayon-core
ayon-core copied to clipboard
ynput
Show Folder thumbnails in Launcher, Workfiles tool, Loader in the Folder Widget.
Changelog Description
Show the folder thumbnails for the folder entries in the Folder Widget, making it how in the Launcher, Workfiles Tool, Loader, etc.
Additional info
Uses a background thread to retrieve the thumbnails to avoid large slow downs.
Just a prototype to show how it could be done.
A draft implementation for: https://github.com/ynput/ayon-core/issues/749 (However this does not show task thumbnails)
Testing notes:
- Run launcher/loader etc. and it should show thumbnails.
- Shouldn't we cache it on disk so each refresh does not re-download all thumbnails on project?
- Shoulnd't we use
thumbnail_idon entities instead of using endpoint to get thumbnail by entity type and id -> which re-downloads the same thumbnail if is the same? - I believe thumbnails should have their model for that, so it's managable at single place.
Shouldn't we cache it on disk so each refresh does not re-download all thumbnails on project?
Shoulnd't we use
thumbnail_idon entities instead of using endpoint to get thumbnail by entity type and id -> which re-downloads the same thumbnail if is the same?I believe thumbnails should have their model for that, so it's managable at single place.
All valid questions - this was merely a prototype. I think, yes - optimization here is good.
Before that though - I wonder about how worth it that really is if e.g. no-one likes the UX this brings. E.g. currently entries without thumbnail are not expanded in the list - sometimes making an 'uneven' list which feels a bit cluttered, etc.
Before that though - I wonder about how worth it that really is if e.g. no-one likes the UX this brings. E.g. currently entries without thumbnail are not expanded in the list - sometimes making an 'uneven' list which feels a bit cluttered, etc.
Agree that the UX is "not friendly", and I'm know to not be the person who can change that. But I can make it happen if someone comes with one 🙂 and I'll get hours to work on it.
Quite frankly there's not much point putting a lot of work into launcher right now as we're planning to replace it with a react UI anyways.
Quite frankly there's not much point putting a lot of work into launcher right now as we're planning to replace it with a react UI anyways.
Note that it isn't dedicated to launcher - it's implementing in the "Folder widget" which is used in launcher, but also in Loader, Workfiles tool inside DCCs, etc.
Hello, this is an awesome feature, I've tested it and the thumbnail shows for the launcher as expected. However, I can't quite get the thumbnail to show for the workfile in ayon workfile.
Additionally, what is the rule for deciding which thumbnail to show for the launcher? It seem to use the thumbnail from the published products, but when are multiple product published how does it know which one to prioritise.
Additionally, what is the rule for deciding which thumbnail to show for the launcher? It seem to use the thumbnail from the published products, but when are multiple product published how does it know which one to prioritise.
It should be using the same thumbnail as the frontend would show on the folder - which can be either set explicitly, or it takes the last published product I believe.
@BigRoy how can we set the thumbnail explicitly?
Also, I just noticed that when there are new thumbnail, I need to restart ayon for the new thumbnail to show up.